freemyipod r730 - Code Review

Jump to: navigation, search
Repository:freemyipod
Revision:< r729‎ | r730 | r731 >
Date:00:59, 12 July 2011
Author:theseven
Status:new
Tags:
Comment:
emCORE: Fix some nonsense in iPod Classic crt0.S that was probably left over from the iPod Nano 2G
Modified paths:
  • /emcore/trunk/target/ipodclassic/crt0.S (modified) (history)

Diff [purge]

Index: emcore/trunk/target/ipodclassic/crt0.S
——@@ -115,11 +115,6 @@
116116 cmp r1, r0
117117 strhi r2, [r0], #4
118118 bhi .clearbss
119 - ldr r1, =0x38200000
120 - ldr r0, [r1]
121 - orr r0, r0, #1
122 - bic r0, r0, #0x10000
123 - str r0, [r1]
124119 .cleancache:
125120 mrc p15, 0, r15,c7,c10,3
126121 bne .cleancache
——@@ -126,17 +121,10 @@
127122 mov r0, #0
128123 mcr p15, 0, r0,c7,c10,4
129124 mcr p15, 0, r0,c7,c5,0
130 - ldr r1, =0x38200000
131 - ldr r0, [r1]
132 - orr r0, r0, #1
133 - bic r0, r0, #0x10000
134 - str r0, [r1]
135 - mov r0, #0
136 - mcr p15, 0, r0,c7,c5,0
137125 add r1, r1, #0x00c00000
138126 add r2, r1, #0x00001000
139127 add r3, r1, #0x00002000
140 - sub r4, r0, #1
 128+ mov r4, #-1
141129 str r4, [r1,#0x14]
142130 str r4, [r2,#0x14]
143131 str r4, [r1,#0xf00]
——@@ -143,8 +131,6 @@
144132 str r4, [r2,#0xf00]
145133 str r4, [r3,#0x08]
146134 str r4, [r3,#0x0c]
147 - str r0, [r1,#0x14]
148 - str r0, [r2,#0x14]
149135 msr cpsr_c, #0xd2
150136 ldr sp, =_irqstackend
151137 msr cpsr_c, #0xd7

Follow-up revisions

RevisionCommit summaryAuthorDate
r743emCORE: iPod Classic: Fix regression caused by r730theseven16:25, 12 July 2011
Retrieved from "https://freemyipod.org/wiki/Special:Code/freemyipod/730"