freemyipod r573 - Code Review

Jump to: navigation, search
Repository:freemyipod
Revision:< r572‎ | r573 | r574 >
Date:14:14, 9 February 2011
Author:theseven
Status:new
Tags:
Comment:
emCORE: Swap the order of the IRQ and abort mode stacks, so that if the IRQ mode stack overflows, it corrupts the abort mode stack before corrupting ibss
Modified paths:
  • /emcore/trunk/target/ipodclassic/ls.x (modified) (history)
  • /emcore/trunk/target/ipodnano2g/ls.x (modified) (history)
  • /emcore/trunk/target/ipodnano3g/ls.x (modified) (history)
  • /emcore/trunk/target/ipodnano4g/ls.x (modified) (history)

Diff [purge]

Index: emcore/trunk/target/ipodnano2g/ls.x
——@@ -73,12 +73,12 @@
7474 _ibssstart = .;
7575 *(.ibss*)
7676 . = ALIGN(0x4);
 77+ _abortstackstart = .;
 78+ . += 0x400;
 79+ _abortstackend = .;
7780 _irqstackstart = .;
7881 . += 0x400;
7982 _irqstackend = .;
80 - _abortstackstart = .;
81 - . += 0x400;
82 - _abortstackend = .;
8383 *(.stack*)
8484 . = ALIGN(0x4);
8585 _ibssend = .;
Index: emcore/trunk/target/ipodnano3g/ls.x
——@@ -73,12 +73,12 @@
7474 _ibssstart = .;
7575 *(.ibss*)
7676 . = ALIGN(0x4);
 77+ _abortstackstart = .;
 78+ . += 0x400;
 79+ _abortstackend = .;
7780 _irqstackstart = .;
7881 . += 0x400;
7982 _irqstackend = .;
80 - _abortstackstart = .;
81 - . += 0x400;
82 - _abortstackend = .;
8383 *(.stack*)
8484 . = ALIGN(0x4);
8585 _ibssend = .;
Index: emcore/trunk/target/ipodnano4g/ls.x
——@@ -73,12 +73,12 @@
7474 _ibssstart = .;
7575 *(.ibss*)
7676 . = ALIGN(0x4);
 77+ _abortstackstart = .;
 78+ . += 0x400;
 79+ _abortstackend = .;
7780 _irqstackstart = .;
7881 . += 0x400;
7982 _irqstackend = .;
80 - _abortstackstart = .;
81 - . += 0x400;
82 - _abortstackend = .;
8383 *(.stack*)
8484 . = ALIGN(0x4);
8585 _ibssend = .;
Index: emcore/trunk/target/ipodclassic/ls.x
——@@ -73,12 +73,12 @@
7474 _ibssstart = .;
7575 *(.ibss*)
7676 . = ALIGN(0x4);
 77+ _abortstackstart = .;
 78+ . += 0x400;
 79+ _abortstackend = .;
7780 _irqstackstart = .;
7881 . += 0x400;
7982 _irqstackend = .;
80 - _abortstackstart = .;
81 - . += 0x400;
82 - _abortstackend = .;
8383 *(.stack*)
8484 . = ALIGN(0x4);
8585 _ibssend = .;
Retrieved from "https://freemyipod.org/wiki/Special:Code/freemyipod/573"