freemyipod r372 - Code Review

Repository:	freemyipod
Revision:	< r371‎ \| r372 \| r373 >
Date:	22:42, 21 December 2010
Author:	theseven
Status:	new
Tags:
Comment:	UMSboot: Fix backlight on iPod Classic
Modified paths:	/umsboot/target/ipodclassic/i2c.c (modified) (history) /umsboot/target/ipodclassic/ls.x (modified) (history)

Diff [purge]

Index: umsboot/target/ipodclassic/ls.x
—	—	@@ -71,8 +71,6 @@
72	72	. = ALIGN(4);
73	73	(.ibss)
74	74	. = ALIGN(4);
75		~~- *(COMMON)~~
76		~~- . = ALIGN(4);~~
77	75	_bssend = .;
78	76	} > SRAM
79	77
—	—	@@ -82,6 +80,8 @@
83	81	. = ALIGN(4);
84	82	(.bss)
85	83	. = ALIGN(4);
	84	+ *(COMMON)
	85	+ . = ALIGN(4);
86	86	_mainstackstart = .;
87	87	. += 0x1000;
88	88	_mainstackend = .;
Index: umsboot/target/ipodclassic/i2c.c
—	—	@@ -35,6 +35,7 @@
36	36	IICDS(bus) = device & ~1;
37	37	IICSTAT(bus) = 0xF0;
38	38	IICCON(bus) = 0xB7;
	39	+ asm volatile("nop\n\t");
39	40	while ((IICCON(bus) & 0x10) == 0);
40	41	if (address >= 0)
41	42	{
—	—	@@ -41,6 +42,7 @@
42	43	/* write address */
43	44	IICDS(bus) = address;
44	45	IICCON(bus) = 0xB7;
	46	+ asm volatile("nop\n\t");
45	47	while ((IICCON(bus) & 0x10) == 0);
46	48	}
47	49	/* write data */
—	—	@@ -48,11 +50,13 @@
49	51	{
50	52	IICDS(bus) = *data++;
51	53	IICCON(bus) = 0xB7;
	54	+ asm volatile("nop\n\t");
52	55	while ((IICCON(bus) & 0x10) == 0);
53	56	}
54	57	/* STOP */
55	58	IICSTAT(bus) = 0xD0;
56	59	IICCON(bus) = 0xB7;
	60	+ asm volatile("nop\n\t");
57	61	while ((IICSTAT(bus) & (1 << 5)) != 0);
58	62	}
59	63