freemyipod r626 - Code Review

Repository:	freemyipod
Revision:	< r625‎ \| r626 \| r627 >
Date:	17:10, 18 February 2011
Author:	theseven
Status:	new
Tags:
Comment:	emCORE: Make sure that executed apps/libs are aligned at cacheline boundaries
Modified paths:	/emcore/trunk/execimage.c (modified) (history)

Diff [purge]

Index: emcore/trunk/execimage.c
—	—	@@ -63,7 +63,7 @@
64	64	size_t tempsize = MAX(finalsize, datasize);
65	65	if (compressed)
66	66	{
67		~~- void* alloc = malloc(tempsize);~~
	67	+ void* alloc = memalign(CACHEALIGN_SIZE, tempsize);
68	68	if (!alloc)
69	69	{
70	70	cprintf(CONSOLE_BOOT, "execimage: Out of memory!\n");
—	—	@@ -81,21 +81,23 @@
82	82	}
83	83	image = alloc;
84	84	}
85		~~- else if (copy)~~
	85	+ else if (copy \|\| (((uint32_t)image) & (CACHEALIGN_SIZE - 1)))
86	86	{
87		~~- void* alloc = malloc(tempsize);~~
	87	+ void* alloc = memalign(CACHEALIGN_SIZE, tempsize);
88	88	if (!alloc)
89	89	{
90	90	cprintf(CONSOLE_BOOT, "execimage: Out of memory!\n");
	91	+ if (!copy) free(image);
91	92	return NULL;
92	93	}
93	94	memcpy(alloc, image + offset, datasize);
	95	+ if (!copy) free(image);
94	96	image = alloc;
95	97	}
96	98	else
97	99	{
98	100	memcpy(image, image + offset, datasize);
99		~~- void* newimage = realloc(image, tempsize);~~
	101	+ void* newimage = realign(image, CACHEALIGN_SIZE, tempsize);
100	102	if (!newimage)
101	103	{
102	104	free(image);