freemyipod r790 - Code Review

Repository:	freemyipod
Revision:	< r789‎ \| r790 \| r791 >
Date:	20:35, 18 November 2011
Author:	user890104
Status:	new
Tags:
Comment:	emCOREFS: fix variable reusing fail, and finally make printing of ssize_t portable
Modified paths:	/emcore/trunk/tools/emcorefs/usb.c (modified) (history)

Diff [purge]

Index: emcore/trunk/tools/emcorefs/usb.c
—	—	@@ -62,7 +62,7 @@
63	63	{
64	64	libusb_device *devs, dev;
65	65	ssize_t devs_cnt;
66		~~- int res, i;~~
	66	+ int res, i, j;
67	67	struct libusb_device_descriptor dev_desc;
68	68	uint8_t found = 0;
69	69	struct libusb_config_descriptor* cfg_desc;
—	—	@@ -82,7 +82,7 @@
83	83	}
84	84
85	85	#ifdef DEBUG
86		~~- fprintf(stderr, "Found %ld USB devices!\n", devs_cnt);~~
	86	+ fprintf(stderr, "Found %Zd USB devices!\n", devs_cnt);
87	87	#endif
88	88	for (i = 0; i < devs_cnt; ++i)
89	89	{
—	—	@@ -164,15 +164,15 @@
165	165	fprintf(stderr, "Endpoints:");
166	166	#endif
167	167
168		~~- for (i = 0; i < 4; ++i)~~
	168	+ for (j = 0; j < 4; ++j)
169	169	{
170		~~- ep_desc = &iface_desc->endpoint[i];~~
	170	+ ep_desc = &iface_desc->endpoint[j];
171	171
172	172	#ifdef DEBUG
173		~~- fprintf(stderr, " %d at 0x%02x", i, ep_desc->bEndpointAddress);~~
	173	+ fprintf(stderr, " %d at 0x%02x", j, ep_desc->bEndpointAddress);
174	174	#endif
175	175
176		~~- switch (i) {~~
	176	+ switch (j) {
177	177	case 0:
178	178	emcore_usb_eps_addr.cout = ep_desc->bEndpointAddress;
179	179	break;