freemyipod r738 - Code Review

Jump to: navigation, search
Repository:freemyipod
Revision:r737‎ | r738 | r739 >
Date:01:05, 12 July 2011
Author:theseven
Status:new
Tags:
Comment:
emCORE: Get rid of hardwired cacheline sizes
Modified paths:
  • /emcore/trunk/target/ipodclassic/storage_ata.c (modified) (history)
  • /emcore/trunk/target/ipodnano3g/lcd.c (modified) (history)
  • /emcore/trunk/target/ipodnano4g/lcd.c (modified) (history)

Diff [purge]

Index: emcore/trunk/target/ipodnano3g/lcd.c
@@ -31,7 +31,7 @@
3232
3333
3434 static struct dma_lli lcd_lli[(LCD_WIDTH * LCD_HEIGHT - 1) / 0xfff]
35 - IDATA_ATTR __attribute__((aligned(16)));
 35+ IDATA_ATTR CACHEALIGN_ATTR;
3636
3737 static uint16_t lcd_color IDATA_ATTR;
3838
Index: emcore/trunk/target/ipodnano4g/lcd.c
@@ -30,7 +30,7 @@
3131
3232
3333 static struct dma_lli lcd_lli[(LCD_WIDTH * LCD_HEIGHT - 1) / 0xfff]
34 - IDATA_ATTR __attribute__((aligned(16)));
 34+ IDATA_ATTR CACHEALIGN_ATTR;
3535
3636 static uint16_t lcd_color IDATA_ATTR;
3737
Index: emcore/trunk/target/ipodclassic/storage_ata.c
@@ -40,8 +40,8 @@
4141
4242
4343 /** static, private data **/
44 -static uint8_t ceata_taskfile[16] __attribute__((aligned(16)));
45 -uint16_t ata_identify_data[0x100] __attribute__((aligned(16)));
 44+static uint8_t ceata_taskfile[16] CACHEALIGN_ATTR;
 45+uint16_t ata_identify_data[0x100] CACHEALIGN_ATTR;
4646 bool ceata;
4747 bool ata_lba48;
4848 bool ata_dma;